Skip to content

Conversation

ragiano215
Copy link
Contributor

Change to default the change feed lag report frequency to 1 min from None. The latter caused both the logging and the emission of the Prometheus metric to not occur. It was deemed that 1 min shouldn't be too costly a default to use.

@ragiano215 ragiano215 force-pushed the lag-frequency-default branch from fb533a9 to 3aa01d7 Compare August 1, 2021 14:25
Copy link
Member

@deviousasti deviousasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ragiano215 ragiano215 force-pushed the lag-frequency-default branch from 3aa01d7 to 59d98d7 Compare August 2, 2021 12:43
@ragiano215 ragiano215 marked this pull request as ready for review August 2, 2021 13:37
@bartelink
Copy link
Collaborator

Thanks for the contribution, much appreciated!

@bartelink bartelink merged commit 8d9337f into jet:master Aug 2, 2021
ragiano215 added a commit to ragiano215/dotnet-templates that referenced this pull request Aug 9, 2021
ragiano215 added a commit to ragiano215/dotnet-templates that referenced this pull request Aug 14, 2021
ragiano215 added a commit to ragiano215/dotnet-templates that referenced this pull request Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants