Skip to content

Add proCosmosReactor for same Container Reactions #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Sep 13, 2021
Merged

Add proCosmosReactor for same Container Reactions #93

merged 22 commits into from
Sep 13, 2021

Conversation

ragiano215
Copy link
Contributor

@ragiano215 ragiano215 commented Jul 22, 2021 •
edited by bartelink
Loading

Adding a new template: proCosmosReactor that is a stripped down derivative of the Propulsion Reactor template for a simpler exposition for:

  • demonstrating usage against just Cosmos
  • command processing is stripped down to use a single container both for listening and writing events to (the full template requires the monitored and target container to be specified separately, even if you're using the same Container for both)

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bartelink
bartelink reviewed Jul 22, 2021
View reviewed changes
bartelink
bartelink reviewed Jul 22, 2021
View reviewed changes
@ragiano215 ragiano215 force-pushed the propulsion-cosmos-reactor branch from 397ba84 to 9a2a5f1 Compare July 23, 2021 21:33
@bartelink
Copy link
Collaborator

template name (and an overview as to the motivation!) should go in the overview - PR title and/or commit when it gets merged should be <60 chars
Also needs to be added to the readme.md (inc putting it in the walkthrough) and the changelog.md

bartelink
bartelink reviewed Aug 2, 2021
View reviewed changes
@ragiano215 ragiano215 changed the title Template for Same Cosmos Source-Destination Container Propulsion Reactor Added proCosmosReactor Template for Same Container Reaction Aug 8, 2021
@ragiano215 ragiano215 force-pushed the propulsion-cosmos-reactor branch from 11837a4 to 7fa5650 Compare August 9, 2021 01:50
bartelink
bartelink reviewed Aug 10, 2021
View reviewed changes
bartelink
bartelink reviewed Aug 10, 2021
View reviewed changes
@ragiano215 ragiano215 force-pushed the propulsion-cosmos-reactor branch from 7fa5650 to b1f5aee Compare August 13, 2021 04:05
bartelink
bartelink reviewed Aug 13, 2021
View reviewed changes
bartelink
bartelink reviewed Aug 13, 2021
View reviewed changes
bartelink
bartelink reviewed Aug 13, 2021
View reviewed changes
@ragiano215 ragiano215 force-pushed the propulsion-cosmos-reactor branch from b1f5aee to b17ce89 Compare August 14, 2021 04:37
bartelink
bartelink reviewed Aug 14, 2021
View reviewed changes
@ragiano215 ragiano215 marked this pull request as ready for review August 14, 2021 12:58
@ragiano215
Base reference state.
5eb7802
@ragiano215
Removed unused constant definition.
cb21f9a 
Propagated to source template.
@ragiano215
Removed comment meant for templated form.
06edef3
@ragiano215
Updated dependencies for Serilog and pinning Microsoft.Azure.Cosmos.
92b1b72 
Propagated to source template.
@ragiano215
Corrected help messages for a few options.
7b490d4
@ragiano215
Re-aligned indentation.
9b51046
@ragiano215
Lined up long piped expression.
b402a5b
@ragiano215
Re-aligned member function definition.
2f4b0dc
@ragiano215
Minor change so Serilog key is consistent: db -> database.
7484f61
@ragiano215
Removed chunk of Argu code for destination in 2-container setup.
579dd74
@ragiano215
Trimmed down Infrastructure.fs for only one client with log emission.
4a845fb
@ragiano215
Corrected last bits for 1-container set up and wiring in build.
8bdf66d
@ragiano215
Per PR comment, made module-level create private.
2cfc015 
Also propagated change to original template.
@ragiano215 ragiano215 force-pushed the propulsion-cosmos-reactor branch from 3b87ed8 to 4aad33b Compare August 14, 2021 13:15
@bartelink bartelink changed the title Added proCosmosReactor Template for Same Container Reaction Add proCosmosReactor for same Container Reactions Aug 14, 2021
bartelink
bartelink reviewed Aug 14, 2021
View reviewed changes
bartelink
bartelink reviewed Aug 14, 2021
View reviewed changes
bartelink
bartelink reviewed Aug 14, 2021
View reviewed changes
bartelink
bartelink reviewed Aug 14, 2021
View reviewed changes
bartelink
bartelink reviewed Aug 14, 2021
View reviewed changes
bartelink
bartelink reviewed Aug 14, 2021
View reviewed changes
@ragiano215 ragiano215 force-pushed the propulsion-cosmos-reactor branch from 4aad33b to 0bccd55 Compare August 14, 2021 15:58
@ragiano215 @bartelink
Added Ruben's suggestions for README.md.
1a4b8b5 
Co-authored-by: Ruben Bartelink <ruben@bartelink.com>
@ragiano215 ragiano215 force-pushed the propulsion-cosmos-reactor branch from 0bccd55 to 1a4b8b5 Compare August 14, 2021 16:03
bartelink
bartelink reviewed Aug 17, 2021
View reviewed changes
bartelink
bartelink reviewed Aug 17, 2021
View reviewed changes
@bartelink
Copy link
Collaborator

Thanks for your contribution (and bearing with all the nitpicking)!

@bartelink bartelink merged commit 8ea8e6e into jet:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartelink bartelink bartelink left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ragiano215 @CLAassistant @bartelink