Skip to content

Fix stray backtick in comment #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix stray backtick in comment #74

merged 1 commit into from
Apr 13, 2022

Conversation

olivercoad
Copy link
Contributor

It was messing up github rendering syntax highlighting of everything after it.

FsCodec/src/FsCodec/StreamName.fs

Lines 40 to 47 in 6e867e9

buf.Append x |> ignore
create category (buf.ToString())
/// <summary>Validates and maps a trusted Stream Name consisting of a Category and an Id separated by a '-` (dash).<br/>
/// Throws <c>InvalidArgumentException</c> if it does not adhere to that form.</summary>
let parse (rawStreamName : string) : StreamName =
if rawStreamName.IndexOf('-') = -1 then
invalidArg "streamName" (sprintf "Stream Name '%s' must contain a '-' separator" rawStreamName)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@deviousasti
Copy link
Member

Good catch Oliver! Thank you for the contribution.

@deviousasti deviousasti merged commit bf96d5b into jet:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olivercoad @CLAassistant @deviousasti