(feat): Lazy load S3 client #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lazy loads the S3 client so it no longer adds ~100 ms to coldstarts if you minify your bundle and don't use S3. If you are using the on disk version of
client-s3
, it reduces coldstarts by ~300ms. By lazy loading you can also omitclient-s3
in a minified bundle if you don't use it reducing the bundled package size by over 340 KB. While making this change I noticed that the call tosetConfig
when using a custom s3 client was in therun
method causing a new S3Client to be created for every request. I moved thesetConfig
call to thecreateAPI
method so the same S3 client is reused across requests.