Skip to content

fix: logger function should accept second arguments #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2022
Merged

fix: logger function should accept second arguments #198

merged 1 commit into from
Dec 20, 2022

Conversation

hassanazharkhan
Copy link
Contributor

Docs show that we could add a second argument in the logger, it's working fine in JS but in TS the typing was only accepting string arguments

@hassanazharkhan
fix: logger function should accept second arguments
a764b37 
Docs show that we could add a second argument in the logger, it's working fine in JS but in TS the typing was only accepting string arguments
@jeremydaly
Copy link
Owner

Thanks, will get this in the next release.

@jaimalchohan jaimalchohan mentioned this pull request Jan 26, 2022
Closed
@hassanazharkhan
Copy link
Contributor Author

@jeremydaly Any chance of this getting merged soon?

@naorpeled naorpeled merged commit 5d29ac7 into jeremydaly:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremydaly jeremydaly jeremydaly approved these changes

@naorpeled naorpeled naorpeled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hassanazharkhan @jeremydaly @naorpeled