Skip to content

Globals cleanup: make protection property writable #15689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2025
Merged

Globals cleanup: make protection property writable #15689

merged 3 commits into from
Jun 19, 2025

Conversation

eyalroth
Copy link
Contributor

Summary

Further fixes to #15678.

@eyalroth
jestjs#15678 [jest-matcher-utils] Make 'deepCyclicCopyObject' safer b…
bf2241e 
…y setting descriptors to null-prototype object
@netlify Netlify
Copy link

netlify bot commented Jun 19, 2025 •
edited
Loading

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 17f270f
🔍 Latest deploy log https://app.netlify.com/projects/jestjs/deploys/6853e44e2b6c7d0008b465ca
😎 Deploy Preview https://deploy-preview-15689--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 19, 2025 •
edited
Loading

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@15689

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@15689

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@15689

create-jest

npm i https://pkg.pr.new/create-jest@15689

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@15689

expect

npm i https://pkg.pr.new/expect@15689

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@15689

jest

npm i https://pkg.pr.new/jest@15689

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@15689

jest-circus

npm i https://pkg.pr.new/jest-circus@15689

jest-cli

npm i https://pkg.pr.new/jest-cli@15689

jest-config

npm i https://pkg.pr.new/jest-config@15689

@jest/console

npm i https://pkg.pr.new/@jest/console@15689

@jest/core

npm i https://pkg.pr.new/@jest/core@15689

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@15689

jest-diff

npm i https://pkg.pr.new/jest-diff@15689

jest-docblock

npm i https://pkg.pr.new/jest-docblock@15689

jest-each

npm i https://pkg.pr.new/jest-each@15689

@jest/environment

npm i https://pkg.pr.new/@jest/environment@15689

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@15689

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@15689

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@15689

@jest/expect

npm i https://pkg.pr.new/@jest/expect@15689

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@15689

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@15689

@jest/globals

npm i https://pkg.pr.new/@jest/globals@15689

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@15689

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@15689

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@15689

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@15689

jest-message-util

npm i https://pkg.pr.new/jest-message-util@15689

jest-mock

npm i https://pkg.pr.new/jest-mock@15689

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@15689

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@15689

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@15689

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@15689

jest-resolve

npm i https://pkg.pr.new/jest-resolve@15689

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@15689

jest-runner

npm i https://pkg.pr.new/jest-runner@15689

jest-runtime

npm i https://pkg.pr.new/jest-runtime@15689

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@15689

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@15689

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@15689

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@15689

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@15689

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@15689

@jest/transform

npm i https://pkg.pr.new/@jest/transform@15689

@jest/types

npm i https://pkg.pr.new/@jest/types@15689

jest-util

npm i https://pkg.pr.new/jest-util@15689

jest-validate

npm i https://pkg.pr.new/jest-validate@15689

jest-watcher

npm i https://pkg.pr.new/jest-watcher@15689

jest-worker

npm i https://pkg.pr.new/jest-worker@15689

pretty-format

npm i https://pkg.pr.new/pretty-format@15689

commit: 8edd0ea

@eyalroth eyalroth changed the title wip Globals cleanup: make protection property writable Jun 19, 2025
@eyalroth eyalroth force-pushed the 15678-globalscleanup-writable branch from 8edd0ea to 17f270f Compare June 19, 2025 10:19
@eyalroth eyalroth marked this pull request as ready for review June 19, 2025 10:20
@eyalroth
Copy link
Contributor Author

@cpojer Let's hope that would be the final fix 🤞

@cpojer cpojer enabled auto-merge (squash) June 19, 2025 10:41
@cpojer cpojer disabled auto-merge June 19, 2025 10:41
@cpojer cpojer merged commit eb075fb into jestjs:main Jun 19, 2025
73 of 75 checks passed
@cpojer
Copy link
Member

cpojer commented Jun 19, 2025

Published as 30.0.2.

@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyalroth @cpojer