Skip to content

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented May 24, 2025

Summary

I wanna use

    "module": "preserve",
    "moduleResolution": "bundler",

but preserve was only added in 5.4: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-4.html#support-for-require-calls-in---moduleresolution-bundler-and---module-preserve.

Note that there is zero changes to the output d.ts files, but since we no longer test against the older versions of TS, I'll call it out in the changelog

Test plan

Copy link

netlify bot commented May 24, 2025

Deploy Preview for jestjs ready!

Name Link
🔨 Latest commit 000ab4c
🔍 Latest deploy log https://app.netlify.com/projects/jestjs/deploys/68318ef1c4af05000821e6e6
😎 Deploy Preview https://deploy-preview-15621--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@SimenB SimenB merged commit e90eb4f into jestjs:main May 24, 2025
85 checks passed
@SimenB SimenB deleted the drop-ts-5.3 branch May 24, 2025 09:25
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants