feat(runtime): use compileFunction over new Script
#15461
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
| '__tests__/b.test.js': "test('b', () => console.log('b'));", | ||
| 'package.json': JSON.stringify({jest: {testEnvironment: 'jsdom'}}), | ||
| }); | ||
| onNodeVersions('> 16', () => { |
There was a problem hiding this comment.
this is unfortunate, but hopefully most people have moved on from node 16 😀
|
The following CI checks should also be removed in this case: |
|
Also: there's a line in the changelog about dropped node versions. v16 should be added to the list |
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one. |
|
This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one. |
|
Node 16 has been EOL for almost two years, so let's drop it for 30. Is the only blocker node 16? |
d72158a to
8ac37f8
Compare
|
Ok, rebased and got rid of the Node 16 check. |
8ac37f8 to
691e4a3
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Reapplies and closes #12205.
Node 16 still has issues (and I don't intend to drop it for Jest 30), but most people are deffo on newer versions than that
Test plan
CI?