Skip to content

Conversation

mrazauskas
Copy link
Contributor

@mrazauskas mrazauskas commented Aug 28, 2022

Summary

Adds admonitions in Global APIs docs. Based on #12776, but with some additional refactoring. Pity that the PR got closed. I would like to see these changes in the docs.

Would be good to rework this document more, there is lots of unnecessary repetition. Thinking about it. First would be good to have admonitions (;

Test plan

Deploy preview.

@Biki-das
Copy link
Contributor

thanks @mrazauskas , i am really busy in doing some stuff, good luck with this one :-)

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimenB SimenB merged commit bf0c78a into jestjs:main Aug 31, 2022
@mrazauskas mrazauskas deleted the docs-global-api-admonitions branch August 31, 2022 10:19
@github-actions
Copy link

github-actions bot commented Oct 1, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants