fixed command line parsing crashed debugger session #1224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/helpers.ts:317
- Confirm that swapping the order to remove quotes before normalization is the intended fix, as this change may affect paths with edge-case characters.
parts[0] = normalize(removeSurroundingQuote(parts[0]));
tests/helpers.test.ts:394
- [nitpick] Ensure that the use of template literals for this test case is intentional to cover unique quoting scenarios and that the expected behavior is fully verified.
${`'c:\jest' --arg1 "escaped \"this\" string" --arg2 2`}
Pull Request Test Coverage Report for Build 14252200457Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #1221
On Windows, when an absolute path command is enclosed in quotes and passed to
parseCmdLine()inhelpers.ts, thepath.normalize()function misinterprets it as a relative path, appending an incorrect relative prefix. This bug surfaces during the generation of the default debug configuration, ultimately causing a crash in the vscode debug session.It seems that previous versions of VS Code might have handled such quoted paths differently, though the precise behavior remains unclear. The fix is straightforward: strip any extraneous quotes from the command line argument before calling
path.normalize(), rather than afterwards.