Skip to content

[bug] Ensure a sync component archive exists before using it #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

[bug] Ensure a sync component archive exists before using it #650

merged 1 commit into from
Apr 25, 2025

Conversation

PierreBtz
Copy link
Contributor

@PierreBtz PierreBtz commented Apr 25, 2025 •
edited
Loading

In case no async component is selected while generating a new bundle, the following stack appears in the logs:

2025-04-25 13:50:46.324+0000 [id=91]	WARNING	c.c.j.support.SupportPlugin#writeBundle: Error while processing sync components in async mode
java.io.FileNotFoundException: /var/folders/jl/z9cm5_452pv9hbm1k6pr0fyc0000gn/T/support-bundle/6faf6b7f-08f4-4414-b8c0-7fc19d49922e/support-bundle.zip (No such file or directory)
	at java.base/java.io.FileInputStream.open0(Native Method)
	at java.base/java.io.FileInputStream.open(FileInputStream.java:213)
	at java.base/java.io.FileInputStream.<init>(FileInputStream.java:152)
	at PluginClassLoader for support-core//com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:522)
	at PluginClassLoader for support-core//com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:406)
	at PluginClassLoader for support-core//com.cloudbees.jenkins.support.SupportAction$SupportBundleAsyncGenerator.compute(SupportAction.java:542)
	at jenkins.util.ProgressiveRendering$1.run(ProgressiveRendering.java:121)
	at jenkins.security.ImpersonatingScheduledExecutorService$1.run(ImpersonatingScheduledExecutorService.java:67)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)

NOTE: it's merely cosmetic the bundle is properly generated, but it's still not a good look

Testing done

Ensured the stack doesn't appear in the log when generating with a single async component (eg Proxy).

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@PierreBtz PierreBtz requested a review from a team as a code owner April 25, 2025 14:16
jglick
jglick approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amending #617 by @nevingeorgesunny.

src/main/java/com/cloudbees/jenkins/support/SupportPlugin.java
binaryOut.putNextEntry(entry);
zis.transferTo(binaryOut);
if (zipFile.exists()) {
try (ZipInputStream zis = new ZipInputStream(new FileInputStream(zipFile))) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(hide WS)

@jglick jglick added the bug label Apr 25, 2025
@jglick jglick enabled auto-merge April 25, 2025 14:25
@jglick jglick merged commit a2a9f06 into jenkinsci:master Apr 25, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PierreBtz @jglick