Collect information about instance startup and shutdown #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collect timings for each init milestone If the startup takes more than a defined initial delay, start collecting thread dumps at regular intervals.
Vlatombe
commented
Apr 17, 2025
| } | ||
| var format = new SimpleDateFormat(DATE_FORMAT); | ||
| for (int i = 0; i < iterations; i++) { | ||
| File threadDumpFile = fileList.file(format.format(new Date(timestamp)) + ".txt"); |
There was a problem hiding this comment.
Suppressed the prefix -ias the timestamp is always different anyway
There was a problem hiding this comment.
(referring to code moved from SlowRequestThreadDumpsGenerator)
| @@ -45,11 +48,41 @@ | |||
| @Extension(ordinal = -100.0) // run this last as it blocks the channel | |||
| public class ThreadDumps extends ObjectComponent<Computer> { | |||
|
|
|||
| private final Logger logger = Logger.getLogger(ThreadDumps.class.getName()); | |||
jglick
reviewed
Apr 17, 2025
| } | ||
| var format = new SimpleDateFormat(DATE_FORMAT); | ||
| for (int i = 0; i < iterations; i++) { | ||
| File threadDumpFile = fileList.file(format.format(new Date(timestamp)) + ".txt"); |
There was a problem hiding this comment.
(referring to code moved from SlowRequestThreadDumpsGenerator)
src/main/java/com/cloudbees/jenkins/support/impl/ThreadDumps.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/jenkins/support/impl/ThreadDumps.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/jenkins/support/startup/ShutdownComponent.java
Show resolved
Hide resolved
src/main/java/com/cloudbees/jenkins/support/startup/ShutdownComponent.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| protected void printTo(PrintWriter out, @NonNull ContentFilter filter) { | ||
| var startTime = ManagementFactory.getRuntimeMXBean().getStartTime(); |
There was a problem hiding this comment.
Beware that this is JVM startup time, so if any servlet listener runs before Jenkins starts (two such examples come to mind in CloudBees CI), you will get a very skewed measurement.
There was a problem hiding this comment.
I think we don't have any better from core for now...
src/main/java/com/cloudbees/jenkins/support/startup/StartupReport.java
Outdated
Show resolved
Hide resolved
jglick
reviewed
Apr 17, 2025
src/main/java/com/cloudbees/jenkins/support/startup/StartupComponent.java
Show resolved
Hide resolved
jglick
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect timings for each init milestone
If the startup takes more than a defined initial delay, start collecting thread dumps at regular intervals, until the startup completes.
We consider that an instance taking more than 5 minutes is slow to start and is worth collecting thread dumps for (
com.cloudbees.jenkins.support.startup.StartupReport.INITIAL_DELAY_SECONDS).Then we take one thread dump every 30 seconds (
com.cloudbees.jenkins.support.startup.StartupReport.RECURRENCE_PERIOD_SECONDS)The timings are collected in
startup-timings.mdwith the following format (values for a development instance)Total startup time : 30 sec
I will also add a similar logic to collect information when the instance terminates and takes more than the expected time.
CloudBees Internal issue
Testing done
Submitter checklist