Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the http client implementation to be based on
httpclient5
.There could be plenty of optimizations as
httpclient5
brings some very cool features, however this is not the goal of this PR.One thing I want to point out is that the test classes
CloseableHttpClientStub
andCloseableHttpResponseStub
had to be moved to another package in order to allow them accessing methods ofhttpclient5
that are package protected.Testing done
Ran
mvn clean verify
Submitter checklist