Skip to content

Conversation

strangelookingnerd
Copy link
Contributor

This PR migrates the http client implementation to be based on httpclient5.
There could be plenty of optimizations as httpclient5 brings some very cool features, however this is not the goal of this PR.

One thing I want to point out is that the test classes CloseableHttpClientStub and CloseableHttpResponseStub had to be moved to another package in order to allow them accessing methods of httpclient5 that are package protected.

Testing done

Ran mvn clean verify

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

* Migrate client implementation to be based on httpclient5
@strangelookingnerd strangelookingnerd marked this pull request as ready for review January 24, 2025 14:50
@strangelookingnerd strangelookingnerd requested a review from a team as a code owner January 24, 2025 14:50
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timja timja merged commit 2a8770f into jenkinsci:master Jan 24, 2025
17 checks passed
@strangelookingnerd strangelookingnerd deleted the migrate_to_httpclient5 branch January 24, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants