Use Palantir Java Format 2.73.0 #702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/palantir/palantir-java-format/releases/tag/2.73.0 shows it was released last week. The git client plugin use of `spotless` needs the Palantir Java Format upgrade to 2.73.0 in order to run `spotless` with Java 25. The Palantir Java Format upgrade does not seem to be required for Jenkins core to run `spotless` with Java 25. Testing done: Confirmed that `mvn spotless:apply` succeeds with Java 25 EA build 28 on Jenkins core with or without this change. Confirmed that `mvn spotless:apply` makes no formatting changes in Jenkins core with this change.
MarkEWaite
added a commit
to MarkEWaite/plugin-pom
that referenced
this pull request
Aug 8, 2025
https://github.com/palantir/palantir-java-format/releases/tag/2.73.0 shows it was released last week. The git client plugin use of `spotless` needs the Palantir Java Format upgrade to 2.73.0 in order to run `spotless` with Java 25. The Palantir Java Format upgrade does not seem to be required for Jenkins core to run `spotless` with Java 25. Matching pull request in the core pom: * jenkinsci/pom#702 Testing done: Confirmed that `mvn spotless:apply` fails with Java 25 EA build 28 on git client plugin without this change. Confirmed that `mvn spotless:apply` succeeds with Java 25 EA build 28 on git client plugin with this change. Confirmed that `mvn spotless:apply` makes no formatting changes in git client plugin with this change.
This was referenced Aug 8, 2025
timja
approved these changes
Aug 8, 2025
MarkEWaite
added a commit
to jenkinsci/plugin-pom
that referenced
this pull request
Aug 8, 2025
https://github.com/palantir/palantir-java-format/releases/tag/2.73.0 shows it was released last week. The git client plugin use of `spotless` needs the Palantir Java Format upgrade to 2.73.0 in order to run `spotless` with Java 25. The Palantir Java Format upgrade does not seem to be required for Jenkins core to run `spotless` with Java 25. Matching pull request in the core pom: * jenkinsci/pom#702 Testing done: Confirmed that `mvn spotless:apply` fails with Java 25 EA build 28 on git client plugin without this change. Confirmed that `mvn spotless:apply` succeeds with Java 25 EA build 28 on git client plugin with this change. Confirmed that `mvn spotless:apply` makes no formatting changes in git client plugin with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Palantir Java Format 2.73.0
Palantir Java Format 2.73.0 was released last week.
The git client plugin use of
spotlessneeds the Palantir Java Format upgrade to 2.73.0 in order to runspotlesswith Java 25.The Palantir Java Format upgrade does not seem to be required for Jenkins core to run
spotlesswith Java 25. This will keep the core pom version of Palantir Java Format consistent with the version needed in the plugin pom.Matching pull request submitted to plugin pom:
Testing done
Confirmed that
mvn spotless:applysucceeds with Java 25 EA build 28 on Jenkins core with or without this change.Confirmed that
mvn spotless:applymakes no formatting changes in Jenkins core with this change.Submitter checklist