Skip to content

getCulpritsOfEmailList() may return null #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2025
Merged

getCulpritsOfEmailList() may return null #367

merged 2 commits into from
Jun 27, 2025

Conversation

nigjo
Copy link
Contributor

@nigjo nigjo commented Jun 6, 2025

getCulpritsOfEmailList() may return null but addRecipients() must not get null values

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

nigjo added 2 commits June 6, 2025 16:46
@nigjo nigjo requested a review from a team as a code owner June 6, 2025 14:57
jglick
jglick approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mailer-plugin/src/main/java/hudson/tasks/MailSender.java

Lines 431 to 438 in 4a43626

if(previousBuild==null && upstreamBuild==null && previousBuildUpstreamBuild==null) {
listener.getLogger().println("Unable to compute the changesets in "+ upstreamProject +". Is the fingerprint configured?");
return null;
}
if(previousBuild==null || upstreamBuild==null || previousBuildUpstreamBuild==null) {
listener.getLogger().println("Unable to compute the changesets in "+ upstreamProject);
return null;
}
FTR

@jglick jglick added the bug label Jun 27, 2025
@jglick jglick added this pull request to the merge queue Jun 27, 2025
Merged via the queue into jenkinsci:master with commit c54d23f Jun 27, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nigjo @jglick