[JENKINS-69353] github-plugin test failure on Java 17 #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Used my admin powers to replay the build with the |
why so? |
|
See JENKINS-69353. Mockito-generated classes contain fields from the |
|
Thanks! A release of this would allow us to get rid of this hack in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serializing mock triggers is no longer supported in Java 17, so instead switch to a pure mock-based approach that does not require serialization. Tested by successfully running
mvn clean verify -Dtest=org.jenkinsci.plugins.github.webhook.subscriber.DefaultPushGHEventListenerTeston both Java 11 and 17.CC @KostyaSha