Skip to content

Conversation

basil
Copy link
Member

@basil basil commented Aug 8, 2022

Not needed for BOM in the short term, but a generally positive maintenance step IMHO. CC @jglick

@basil
Copy link
Member Author

basil commented Aug 8, 2022

Used my admin powers to replay the run with the Jenkinsfile changes: https://ci.jenkins.io/job/Plugins/job/github-plugin/job/PR-289/3/

@@ -50,7 +50,7 @@
<revision>1.34.6</revision>
<changelist>-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/github-plugin</gitHubRepo>
<jenkins.version>2.346.1</jenkins.version>
<jenkins.version>2.357</jenkins.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or prep for LTS

Suggested change
<jenkins.version>2.357</jenkins.version>
<jenkins.version>2.361</jenkins.version>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stated purpose of this PR is to adapt to instance-identity changes, not to prep for LTS.

@basil
Copy link
Member Author

basil commented Aug 8, 2022

CC @KostyaSha A merge and release of this PR would help us to plugin compatibility testing against this plugin after the instance-identity split in 2.357.

@basil
Copy link
Member Author

basil commented Aug 11, 2022

@oleg-nenashev @KostyaSha Gentle ping. A merge and release of this plugin would facilitate PCT testing for the forthcoming 2.361.1 LTS release.

@KostyaSha KostyaSha merged commit f3e5932 into jenkinsci:master Aug 11, 2022
@basil basil deleted the instance-identity branch August 11, 2022 18:17
@basil
Copy link
Member Author

basil commented Aug 11, 2022

Thanks for merging this PR, @KostyaSha! The CI build is green. Are you interested in performing a release? The latter would help the core maintainers do plugin compatibility testing (PCT) in preparation for the forthcoming 2.361.1 LTS release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants