Avoid eager Jenkins items lookup in the webhook cleaner. #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use lazy iterable of all items instead of using eager list of all the items that is stored locally but immediately converted to the iterable.
|
Bother! Two new SpotBug issues in the files that I didn't even touch 😢 |
|
@Vlatombe do you know if maybe these two new unexpected SpotBug issues in |
|
@duemir There are 19 spotbugs issues on master (same as in this PR), even before the annotations change. No idea how spotbugs think these are new. |
|
@KostyaSha maybe you have some ideas or comments? |
|
Bummer! Rebuild didn't help 😞 |
|
Yey! SpotBug cleaned up after merging the latest |
|
@lanwen @oleg-nenashev, maybe you can review and merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use lazy iterable of all items instead of using an eager list of all the items that is stored in a local variable but immediately converted to the iterable.
I was looking through the heap dump in Eclipse MAT. Most of the memory was just taken by the WorkflowRun objects. It caught my attention that the Cleaner thread featured prominently in the Leak report. I looked into it and thought it could be improved a bit. Functionally nothing should change, the thread just no longer directly references all the items for the duration of execution.
I have also taken a chance to refactor the anonymous classes into lambdas in the functional utility class
JobInfoHelpers.