Remove unnecessary branch retrieval loop (JENKINS-65796) #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be honest, I don't know how to provide tests for this. Any help or hint is appreciated. |
9cec1ca to
ca8e07a
Compare
lafriks
approved these changes
Jun 13, 2021
The mentioned Gitea bug go-gitea/gitea#2088 was fixed years ago.
44c606d to
a6c7962
Compare
lafriks
approved these changes
Oct 27, 2021
justusbunsi
added a commit
to justusbunsi/gitea-plugin
that referenced
this pull request
Nov 22, 2021
As a result of PR jenkinsci#29 it happens that some users cannot fetch branches with slashes in their names anymore. Regression from: JENKINS-65796
lafriks
pushed a commit
that referenced
this pull request
Nov 24, 2021
As a result of PR #29 it happens that some users cannot fetch branches with slashes in their names anymore. Regression from: JENKINS-65796
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mentioned Gitea bug go-gitea/gitea#2088 was fixed years ago. I always use branch patterns like
<bug|feature|task>/<summarized-content>which is exactly the kind of branches for which all branches are fetched to get the only one that is needed. In my environment this takes about 20 seconds, speaking of repositories with more than 400 branches.With this fix, this part of the build takes only 200ms.
Fixes: https://issues.jenkins.io/browse/JENKINS-65796