Branch discovery: Add strategy for all branches that also files PRs and master / main branch #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ND master/main branch
6 tasks
lafriks
reviewed
May 23, 2022
src/main/java/org/jenkinsci/plugin/gitea/BranchDiscoveryTrait.java
Outdated
Show resolved
Hide resolved
lafriks
reviewed
May 23, 2022
src/main/resources/org/jenkinsci/plugin/gitea/Messages.properties
Outdated
Show resolved
Hide resolved
lafriks
requested changes
May 23, 2022
src/main/java/org/jenkinsci/plugin/gitea/BranchDiscoveryTrait.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugin/gitea/BranchDiscoveryTrait.java
Outdated
Show resolved
Hide resolved
src/main/resources/org/jenkinsci/plugin/gitea/Messages.properties
Outdated
Show resolved
Hide resolved
…java Co-authored-by: Lauris BH <lauris@nix.lv>
…java Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: Lauris BH <lauris@nix.lv>
lafriks
approved these changes
Jun 7, 2022
|
@lafriks ping |
|
Sorry for the delay, I was hoping for a second pair of eyes to review this but let's hope it's ok, at least from my side it looked ok |
Sorry for not reviewing. It actually went out of my sight. My bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch discovery strategy: "Only branches that also filed as PRs" excludes "master" / "main".
This pr adds a new branch discovery strategy that offers to discover branches with open PRs and/or the master/main branch.
I couldn't find an exact issue for this, but there is one for the github-branch-source-plugin.
https://issues.jenkins.io/browse/JENKINS-66102