Skip to content

Conversation

MarkEWaite
Copy link
Contributor

[JENKINS-76026] Do not show merges in changelog

Git client 6.3.1 adapted the git client plugin to support command line git 2.51.0 where the "whatchanged" command has been deprecated. However, the change introduced an inconsistency between the CLI git implementation and the JGit implementation.

Prior to git client plugin 6.3.1, the changelog skipped merge commits in all cases.

With git client 6.3.1, the CLI git changelog includes merge commits. With git client 6.3.1, the JGit changelog does not include merge commits.

Testing done

  • Confirmed the bug with interactive testing of git client plugin 6.3.1
  • Wrote an automated test that shows the inconsistency
  • Confirmed that the automated test passes with git client 6.3.1 for JGit
  • Confirmed that the automated test fails with git client 6.3.1 for CLI git and passes with the fix

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

Git client 6.3.1 adapted the git client plugin to support command line
git 2.51.0 where the "whatchanged" command has been deprecated.  However,
the change introduced an inconsistency between the CLI git implementation
and the JGit implementation.

Prior to git client plugin 6.3.1, the changelog skipped merge commits
in all cases.

With git client 6.3.1, the CLI git changelog includes merge commits.
With git client 6.3.1, the JGit changelog does not include merge commits.

Testing done:

* Confirmed the bug with interactive testing of git client plugin 6.3.1
* Wrote an automated test that shows the inconsistency
* Confirmed that the automated test fails with git client 6.3.1 and
  passes with the fix
@MarkEWaite MarkEWaite added the bug Incorrect or flawed behavior label Aug 23, 2025
@MarkEWaite MarkEWaite requested a review from a team as a code owner August 23, 2025 15:09
@MarkEWaite MarkEWaite added the bug Incorrect or flawed behavior label Aug 23, 2025
@github-actions github-actions bot added the tests Automated test addition or improvement label Aug 23, 2025
@MarkEWaite MarkEWaite merged commit 358e279 into jenkinsci:master Aug 23, 2025
18 checks passed
@MarkEWaite MarkEWaite deleted the exclude-merge-commits-from-changelog branch August 23, 2025 15:59
basil pushed a commit to basil/git-client-plugin that referenced this pull request Sep 3, 2025
Git client 6.3.1 adapted the git client plugin to support command line
git 2.51.0 where the "whatchanged" command has been deprecated.  However,
the change introduced an inconsistency between the CLI git implementation
and the JGit implementation.

Prior to git client plugin 6.3.1, the changelog skipped merge commits
in all cases.

With git client 6.3.1, the CLI git changelog includes merge commits.
With git client 6.3.1, the JGit changelog does not include merge commits.

Testing done:

* Confirmed the bug with interactive testing of git client plugin 6.3.1
* Wrote an automated test that shows the inconsistency
* Confirmed that the automated test fails with git client 6.3.1 and
  passes with the fix

(cherry picked from commit 358e279)
MarkEWaite added a commit that referenced this pull request Sep 3, 2025
Git client 6.3.1 adapted the git client plugin to support command line
git 2.51.0 where the "whatchanged" command has been deprecated.  However,
the change introduced an inconsistency between the CLI git implementation
and the JGit implementation.

Prior to git client plugin 6.3.1, the changelog skipped merge commits
in all cases.

With git client 6.3.1, the CLI git changelog includes merge commits.
With git client 6.3.1, the JGit changelog does not include merge commits.

Testing done:

* Confirmed the bug with interactive testing of git client plugin 6.3.1
* Wrote an automated test that shows the inconsistency
* Confirmed that the automated test fails with git client 6.3.1 and
  passes with the fix

(cherry picked from commit 358e279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect or flawed behavior tests Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant