Explicitly declare bundled artifacts #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not allow additions to the bundled dependencies without a change to the list of bundledArtifacts. Avoid the mistakes made in the past when a new transitive dependency was inadvertently added to the plugin and bundled into the hpi / jpi file. Draft until the release of pull request: * jenkinsci/maven-hpi-plugin#771 Testing done: Confirmed that compilation passes and a single test passes. Rely on ci.jenkins.io for more complete testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly declare bundled artifacts
Do not allow additions to the bundled dependencies without a change to the list of bundledArtifacts. Avoid the mistakes made in the past when a new transitive dependency was inadvertently added to the plugin and bundled into the hpi / jpi file.
Draft until the release of pull request:
Testing done
Confirmed that compilation passes and a single test passes. Rely on ci.jenkins.io for more complete testing
Submitter checklist