Skip ssh host tests on ci.jenkins.io #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub.com SSH abuse prevention system rejects connections from the tests when they are run on ci.jenkins.io. These tests should only be run as end to end acceptance tests but they are not too disruptive (for now) to continue to be included in the default tests. Additional tests should be created that use test containers so that they can use the ssh connection on the test container instead of using the GitHub.com SSH servers. Unfortunately, I can't prioritize that test rewrite now, so these tests are disabled on ci.jenkins.io.
MarkEWaite
added a commit
that referenced
this pull request
Feb 14, 2025
The GitHub.com SSH abuse prevention system rejects connections from the tests when they are run on ci.jenkins.io. These tests should only be run as end to end acceptance tests but they are not too disruptive (for now) to continue to be included in the default tests. Additional tests should be created that use test containers so that they can use the ssh connection on the test container instead of using the GitHub.com SSH servers. Unfortunately, I can't prioritize that test rewrite now, so these tests are disabled on ci.jenkins.io. (cherry picked from commit 2d90e37)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip ssh host verifier tests on ci.jenkins.io
The GitHub SSH abuse prevention system rejects connections from the tests when they are run on ci.jenkins.io. These tests should only be run as end to end acceptance tests but they are not too disruptive (for now) to continue to be included in the default tests.
Additional tests should be created that use test containers so that they can use the ssh connection on the test container instead of using the GitHub.com SSH servers.
Unfortunately, I can't prioritize that test rewrite now, so these tests are disabled on ci.jenkins.io.
Testing done
Confirmed that automated tests pass locally where the tests are not excluded. Final confirmation on ci.jenkins.io where the tests will fail if not excluded.
Submitter checklist