Skip to content

Upgrade HtmlUnit from 2.x to 3.x #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2023
Merged

Upgrade HtmlUnit from 2.x to 3.x #136

merged 2 commits into from
Jun 26, 2023

Conversation

timja-bot
Copy link

This is an autogenerated PR for updating HtmlUnit

It follows the migration guide

Migration steps for cases the script can't handle

This migration currently can't handle HtmlOption changes properly.
If it fails to compile on HtmlOption then revert the specific case:

--- a/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
+++ b/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
@@ -114,7 +114,7 @@ public class ExtendedEmailPublisherDescriptorTest {
      assertEquals(
              "Plain text should be selected by default",
              "text/plain",
-                contentType.getSelectedOptions().get(0).getValue());
+                contentType.getSelectedOptions().get(0).getValueAttribute());

Ping @timja if any questions

script source

@timja-bot timja-bot requested a review from a team as a code owner June 6, 2023 07:42
@timja-bot timja-bot added the dependencies Pull requests that update a dependency file label Jun 6, 2023
basil
basil previously requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

java.lang.NoClassDefFoundError: com/gargoylesoftware/htmlunit/WebRequest

@basil basil dismissed their stale review June 16, 2023 22:22

stale

@MarkEWaite MarkEWaite mentioned this pull request Jun 16, 2023
Closed
@MarkEWaite
Copy link
Contributor

This pull request needs to be merged and released before the docker-commons plugin can be included in the plugin bill of materials. Without this pull request, the plugin fails tests with Jenkins 2.410.

See:

@jglick jglick added developer and removed dependencies Pull requests that update a dependency file labels Jun 26, 2023
@jglick jglick merged commit 9d1a89c into jenkinsci:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil left review comments

Assignees
No one assigned
Labels
developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timja-bot @MarkEWaite @basil @jglick @timja