docker login - get password from stdin #86
Conversation
|
Can this PR please be considered for merging? If there are any issues with it please let me know. Thanks! |
|
@rsandell @oleg-nenashev this PR looks complete and addresses some open issues (i found myself here after running into an issue with a password containing an $ today) There are a few other PRs that look complete, but do not have further activity. Is this plugin still maintained? Has there been any discussion on potentially taking on more maintainers? |
|
More maintainers are always welcome! Personally I have difficulties with
maintaining all the things now:
https://twitter.com/oleg_nenashev/status/1376806410768498689?s=19
…On Wed, Apr 21, 2021, 21:55 tschaible ***@***.***> wrote:
@rsandell <https://github.com/rsandell> @oleg-nenashev
<https://github.com/oleg-nenashev> this PR looks complete and addresses
some open issues (i found myself here after running into an issue with a
password containing an $ today)
There are a few other PRs that look complete, but do not have further
activity.
Is this plugin still maintained? Has there been any discussion on
potentially taking on more maintainers?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#86 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RIDS2XOITXMWP36NMIDTJ4URVANCNFSM4LGTQEYQ>
.
|
|
Is there any guidance on how to be more involved and potentially be a maintainer. I've read the Jenkins guidance for "Adopt a Plugin", but it says the following.
That seems to apply to this plugin, so I'm just not sure how to get started in helping to move things forward. |
|
@rsandell - any chance you could please review this? |
|
@jbiel – we are also experiencing the same issue, and I tried to update the plugin with that artifact, but now I'm getting the following error: Any idea? |
|
This seems to break things for many people, see https://issues.jenkins.io/browse/JENKINS-69432 and https://issues.jenkins.io/browse/JENKINS-69436 |
|
This broke all of our builds, i would appreciate detailed usage description or a proper fix |
[JENKINS-69432, JENKINS-69436] Revert #86 "docker login - get password from stdin"
|
Reverted in v. 1.21 |
This patch causes the
docker loginprocess to read the password from stdin rather than as an argument. Using an argument for the password causes issues with complex passwords (such as the JSON documents needed GCR) or passwords with special shell characters ($ especially.)The
--password-stdinflag was introduced in Docker version 17.07.0 so it's been around for a decent amount of time by now. The oldest supported version that doesn't have this flag (enterprise 17.06) is EOL on 2020-04-16, so perhaps this change could be merged in after that date.This change will solve these open issues:
https://issues.jenkins-ci.org/browse/JENKINS-52761
https://issues.jenkins-ci.org/browse/JENKINS-53770