Skip to content

Remove icon-shim dependency #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2017
Merged

Remove icon-shim dependency #61

merged 5 commits into from
Oct 10, 2017

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 10, 2017

Not sure why it was here—was actually older than what you would get by default anyway. Cf. jenkinsci/plugin-pom#72.

@reviewbybees

@jglick jglick requested a review from oleg-nenashev October 10, 2017 14:34
@ghost
Copy link

ghost commented Oct 10, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

oleg-nenashev
oleg-nenashev approved these changes Oct 10, 2017
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝 though it needs JTH/Plugin POM release

pom.xml Outdated
@@ -33,6 +33,7 @@
<properties>
<jenkins.version>1.642.4</jenkins.version>
<java.level>7</java.level>
<jenkins-test-harness.version>2.30-20171010.153224-1</jenkins-test-harness.version> <!-- TODO https://github.com/jenkinsci/jenkins-test-harness/pull/78 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose to release JTH and Plugin POM before merging this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, would do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, JTH at least. plugin-pom can come along later, not urgent.

@jglick jglick merged commit 963c88a into jenkinsci:master Oct 10, 2017
@jglick jglick deleted the icon-shim branch October 10, 2017 23:20
@KostyaSha
Copy link
Member

Not sure why it was here

Because of docker-traceability. Lol, seems I remember introduced docker chaos better.

@KostyaSha
Copy link
Member

So now you broke dependent plugins??
I guess identity was needed for https://github.com/jenkinsci/docker-traceability-plugin/blob/master/docker-traceability-plugin/pom.xml#L141
And icon shim for docker icons.

@jglick
Copy link
Member Author

jglick commented Oct 11, 2017

It should still get icon-shim from core. A slightly later version in fact.

@KostyaSha
Copy link
Member

@jglick Then it looks safe. Afair this plugin was created as piece of traceability and later reused in other plugins.

@timja timja mentioned this pull request Jan 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jglick @KostyaSha @oleg-nenashev