Skip to content

role-strategy-plugin assignments changed in new version of jenkins #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 10, 2023
Merged

role-strategy-plugin assignments changed in new version of jenkins #2334

merged 4 commits into from
Aug 10, 2023

Conversation

shashwot
Copy link
Contributor

@shashwot shashwot commented Aug 10, 2023 •
edited
Loading

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

@shashwot shashwot requested a review from a team as a code owner August 10, 2023 05:12
timja
timja approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right although surprised this isn't tested automatically and the dependency didn't need to be bumped

@timja timja added the test A PR that adds to testing - used by Release Drafter label Aug 10, 2023
@timja timja merged commit 00f9ee1 into jenkinsci:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

Assignees
No one assigned
Labels
test A PR that adds to testing - used by Release Drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shashwot @timja