Skip to content

Add example for matrix-auth version 3.0 #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2022
Merged

Add example for matrix-auth version 3.0 #2174

merged 3 commits into from
Nov 25, 2022

Conversation

human33
Copy link
Contributor

@human33 human33 commented Nov 25, 2022

Hi, I added an example of permission for matrix-auth version above 3.0. Github issue

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

@human33 human33 requested a review from a team as a code owner November 25, 2022 13:24
timja
timja requested changes Nov 25, 2022
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the main example. 3.0 has been out for a long time

@codecov
Copy link

codecov bot commented Nov 25, 2022 •
edited
Loading

Codecov Report

Merging #2174 (f33a246) into master (9d12901) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2174   +/-   ##
=========================================
  Coverage     80.96%   80.96%           
  Complexity      843      843           
=========================================
  Files            72       72           
  Lines          2506     2506           
  Branches        352      352           
=========================================
  Hits           2029     2029           
  Misses          365      365           
  Partials        112      112

@human33
Copy link
Contributor Author

human33 commented Nov 25, 2022

Please update the main example. 3.0 has been out for a long time

@timja Hi, updated the example and changed required version too.

timja
timja reviewed Nov 25, 2022
View reviewed changes
@human33 @timja
Mark anonymous as a USER
f33a246 
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
@timja timja added the documentation A PR that adds to documentation - used by Release Drafter label Nov 25, 2022
@timja timja merged commit fdf7b7b into jenkinsci:master Nov 25, 2022
@timja
Copy link
Member

timja commented Nov 25, 2022

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

Assignees
No one assigned
Labels
documentation A PR that adds to documentation - used by Release Drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@human33 @timja