[Docs] CONTRIBUTING.md Remove java 8 remarks - java 11 works #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2148 +/- ##
=========================================
Coverage 80.96% 80.96%
Complexity 843 843
=========================================
Files 72 72
Lines 2506 2506
Branches 352 352
=========================================
Hits 2029 2029
Misses 365 365
Partials 112 112 |
timja
approved these changes
Oct 15, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the Java 8 specific stuff. I tested it with a clean environment with Java 11, Maven and IntelliJ that it works as expected.
I just did small tests on Java 17, but that also seemed to work
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.