Skip to content

Initiate new LTS baseline 2.361.x #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2022
Merged

Initiate new LTS baseline 2.361.x #2093

merged 1 commit into from
Aug 11, 2022

Conversation

krisstern
Copy link
Member

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes (N/A)
  • Did you provide a test-case? That demonstrates feature works or fixes the issue. (N/A)

Description

Concerns jenkins-infra/release#275

@krisstern krisstern requested a review from a team as a code owner August 10, 2022 08:00
@krisstern krisstern mentioned this pull request Aug 10, 2022
Closed
37 tasks
@timja timja added the chore a PR that adds to maintenance - used by Release Drafter label Aug 10, 2022
@jetersen
Copy link
Member

jetersen commented Aug 10, 2022 •
edited
Loading

I think we need a newer bom specifically for the integration tests

@NotMyFault NotMyFault mentioned this pull request Aug 10, 2022
Merged
@NotMyFault
Copy link
Member

I think we need a newer bom specifically for the integration tests

Tests should now pass with #2095 merged, rebasing with master will show the results 🤞🏻

@jetersen
Copy link
Member

@krisstern has setup the PR with no permissions for maintainers to push updates 😅

So I cannot rebase the PR or merge in master.

@krisstern
Copy link
Member Author

@jetersen I have already enabled "Allow edits and access to secrets by maintainers" for this PR, it's weird you cannot push updates to it...

Anyways I have fetched the latest updates to the master branch and have rebased the PR following it.

@NotMyFault NotMyFault mentioned this pull request Aug 11, 2022
Merged
@NotMyFault
Copy link
Member

More work needs to be done, I created #2099 as test run.

Regular tests are passing now.

@jetersen
Copy link
Member

@krisstern odd I still cannot do merge or push to this PR, however seems like @timja was able to.

@krisstern
Copy link
Member Author

@jetersen Yeah, that's pretty odd...

@timja
Copy link
Member

timja commented Aug 11, 2022

@krisstern odd I still cannot do merge or push to this PR, however seems like @timja was able to.

yup i could at least in github ui

@jetersen
Copy link
Member

yup i could at least in github ui

I tried both locally using gh pr checkout and also looking at the GitHub UI the option is not available. 😭

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #2093 (61faca6) into master (94efed0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2093   +/-   ##
=========================================
  Coverage     81.00%   81.00%           
  Complexity      844      844           
=========================================
  Files            72       72           
  Lines          2506     2506           
  Branches        352      352           
=========================================
  Hits           2030     2030           
  Misses          365      365           
  Partials        111      111

@jetersen jetersen enabled auto-merge (squash) August 11, 2022 15:06
@NotMyFault
Copy link
Member

LGTM doesn't look good to me this time, possibly an auto merge blocker? (If we get a green light on ci.j)

@jetersen
Copy link
Member

Not a blocker

@jetersen jetersen merged commit 6bfec10 into jenkinsci:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetersen jetersen jetersen approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
chore a PR that adds to maintenance - used by Release Drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krisstern @jetersen @NotMyFault @timja