Skip to content

Limit concurrency on workflow #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Limit concurrency on workflow #1843

merged 2 commits into from
Jan 27, 2022

Conversation

jetersen
Copy link
Member

@jetersen jetersen commented Jan 27, 2022

We have too many checks and limitation on the build queue so it gets stuck for hours.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

@jetersen jetersen requested a review from a team as a code owner January 27, 2022 12:38
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this will work won’t it cancel a release too?

@jetersen
Copy link
Member Author

jetersen commented Jan 27, 2022

Potentially but it is better than blocking the entire github action queue for hours?

We should find a better way to trigger releases than listen on check_run completed...

Perhaps have the existing GitHub workflow once all tests passes start the next job that verifies release is necessary?

Like: https://github.com/JanDeDobbeleer/oh-my-posh/blob/main/.github/workflows/release.yml

@jetersen
Copy link
Member Author

Again https://github.com/jenkinsci/configuration-as-code-plugin/actions/workflows/cd.yaml created 55 runs before even getting one release out the door.

@jetersen
Copy link
Member Author

We can also entirely remove on check_run and have it as workflow dispatch.

@timja
Copy link
Member

timja commented Jan 27, 2022

We can also entirely remove on check_run and have it as workflow dispatch.

That may be simplest trivial to hit the button, each action should only take 5 seconds to complete but I assume there's a queue problem that means it doesn't scale.

We could also reduce our github CI down just to running codecov?

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #1843 (3f0ba44) into master (e8cfa34) will not change coverage.
The diff coverage is n/a.

❗ Current head 3f0ba44 differs from pull request most recent head 06fa33b. Consider uploading reports for the commit 06fa33b to get more accurate results

@@            Coverage Diff            @@
##             master    #1843   +/-   ##
=========================================
  Coverage     80.78%   80.78%           
  Complexity      838      838           
=========================================
  Files            71       71           
  Lines          2467     2467           
  Branches        346      346           
=========================================
  Hits           1993     1993           
  Misses          366      366           
  Partials        108      108           

@jetersen jetersen requested a review from timja January 27, 2022 15:15
@timja timja added the chore a PR that adds to maintenance - used by Release Drafter label Jan 27, 2022
@timja timja changed the title limit concurrency on workflow Limit concurrency on workflow Jan 27, 2022
@timja timja merged commit c0cf080 into master Jan 27, 2022
@timja timja deleted the jetersen-patch-1 branch January 27, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a PR that adds to maintenance - used by Release Drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants