-
Notifications
You must be signed in to change notification settings - Fork 733
Limit concurrency on workflow #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this will work won’t it cancel a release too?
Potentially but it is better than blocking the entire github action queue for hours? We should find a better way to trigger releases than listen on check_run completed... Perhaps have the existing GitHub workflow once all tests passes start the next job that verifies release is necessary? Like: https://github.com/JanDeDobbeleer/oh-my-posh/blob/main/.github/workflows/release.yml |
Again https://github.com/jenkinsci/configuration-as-code-plugin/actions/workflows/cd.yaml created 55 runs before even getting one release out the door. |
We can also entirely remove |
That may be simplest trivial to hit the button, each action should only take 5 seconds to complete but I assume there's a queue problem that means it doesn't scale. We could also reduce our github CI down just to running codecov? |
Codecov Report
@@ Coverage Diff @@
## master #1843 +/- ##
=========================================
Coverage 80.78% 80.78%
Complexity 838 838
=========================================
Files 71 71
Lines 2467 2467
Branches 346 346
=========================================
Hits 1993 1993
Misses 366 366
Partials 108 108 |
We have too many checks and limitation on the build queue so it gets stuck for hours.
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.