Skip to content

Initiate new LTS baseline 2.361.x #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

krisstern
Copy link
Member

Checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue (N/A)

Description

Concerns jenkins-infra/release#275

@krisstern krisstern mentioned this pull request Aug 9, 2022
37 tasks
<bom>2.361.x</bom>
<jenkins.version>2.361.1</jenkins.version>
</properties>
</profile>
<profile>
<id>2.346.x</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You ought bump this profile to when adding new LTS line. See the comment on line: 548

<jenkins.version>2.346.2</jenkins.version>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment outlines that .1, .3 or a later build should be used.
I'd recommend we stick to that and use .3, which I'll release tomorrow.

Copy link
Member

@jetersen jetersen Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment is meant to just refer to the "latest" LTS build once we move the next minor LTS.

I guess timing wise that means we will always have .3 because an assumption is made on the release windows.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, guys! I will make a change after the release to use <jenkins.version>2.346.3</jenkins.version> over the next few days, most likely the day after tomorrow

Copy link
Member

@NotMyFault NotMyFault Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess timing wise that means we will always have .3 because an assumption is made on the release windows.

Yeah, Tim was very early with his post this time. Timeframe wise, these kinds or PRs are typically created after the last point release took place.
Btw, doesn't updatecli take care of bumping the point release by now?

Copy link
Member

@jetersen jetersen Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @NotMyFault your absolutely right 👍 completely forgot! I even made it like that 🙄

@krisstern Lets leave the jenkins.version as it is for 2.346.x and hope the updatecli manifest generator picks up bumping jenkins.version once this is merged 👏

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @jetersen

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krisstern see #1390 updatecli already picked up the update 👏

Have left it draft for now, cause of @basil concerns

Co-authored-by: Joseph Petersen <me@jetersen.dev>
Co-authored-by: Alexander Brandes <brandes.alexander@web.de>
@timja timja requested a review from jetersen August 9, 2022 15:40
@timja timja added the enhancement New feature or request label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants