Skip to content

Make this snippet compatible with Spotless #5534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2025
Merged

Conversation

daniel-beck
Copy link
Member

I copied & pasted this and Spotless immediately complained:

[ERROR]     pom.xml
[ERROR]         @@ -47,8 +47,8 @@
[ERROR]          ········<groupId>io.jenkins.tools.bom</groupId>
[ERROR]          ········<artifactId>bom-${jenkins.baseline}.x</artifactId>
[ERROR]          ········<version>5054.v620b_5d2b_d5e6</version>
[ERROR]         +········<type>pom</type>
[ERROR]          ········<scope>import</scope>
[ERROR]         -········<type>pom</type>
[ERROR]          ······</dependency>
[ERROR]          ····</dependencies>
[ERROR]          ··</dependencyManagement>

Lazy origin branch, please delete on merge.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@daniel-beck daniel-beck requested a review from a team as a code owner August 16, 2025 09:57
Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timja timja merged commit a026694 into master Aug 16, 2025
1 of 5 checks passed
@timja timja deleted the spotless-compatibility branch August 16, 2025 10:03
@timja timja added chore Reduces future maintenance documentation Improvements or additions to documentation and removed chore Reduces future maintenance labels Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants