Skip to content

Update the hpi-version to an updated incrementals version #5173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 9, 2025
Merged

Update the hpi-version to an updated incrementals version #5173

merged 12 commits into from
Jun 9, 2025

Conversation

darinpope
Copy link
Contributor

@darinpope darinpope commented Jun 9, 2025 •
edited
Loading

The incremental 3.62-rc1681.2ef7cf8c1fe3 was garbage collected in the past few days since it was in the incrementals repository and was older than 90 days. This was causing all bom builds to fail.

Updating to the latest incrementals version (3.66-rc1721.f952cc39b_d8f).

Update...used a new incrementals build performed by @timja (see comments below)

Testing done

  • export CI=true
  • bash prep.sh

NOTE: the CI=true gets you into the path where the incremental is used.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

darinpope added 10 commits April 29, 2025 15:14
@darinpope darinpope requested a review from a team as a code owner June 9, 2025 13:39
@darinpope darinpope requested a review from basil June 9, 2025 13:40
@darinpope
Copy link
Contributor Author

ok...even with changing the version to 3.66-rc1724.62ed6b_cf44b_b_ to see if there was something magic in the incrementals, I'm consistently getting the following error in the PR build:

+ mv sample-plugin/target/commit-hashes.txt target/commit-hashes-weekly.txt
mv: cannot stat 'sample-plugin/target/commit-hashes.txt': No such file or directory

and it's not jumping out to me why commit-hashes.txt isn't being created.

@timja
Copy link
Member

timja commented Jun 9, 2025

You need an incremental built from this PR: jenkinsci/maven-hpi-plugin#464

I've just triggered a build

@darinpope
Copy link
Contributor Author

When I add the local environment variable:

CI=true

I get the failure locally, so I can reproduce locally. Testing with older incrementals to see if something changed with commitHashes.

@darinpope
Copy link
Contributor Author

You need an incremental built from this PR: jenkinsci/maven-hpi-plugin#464

I've just triggered a build

Thanks. I'll grab it once it's done.

@darinpope darinpope removed the request for review from basil June 9, 2025 15:39
@darinpope darinpope merged commit 1e3baf3 into jenkinsci:master Jun 9, 2025
5 checks passed
@darinpope darinpope changed the title Update the hpi-version to a current release version Update the hpi-version to an updated incrementals version Jun 9, 2025
@darinpope darinpope deleted the update-tools branch June 9, 2025 15:53
@jglick
Copy link
Member

jglick commented Jun 20, 2025

Why can we not just merge jenkinsci/maven-hpi-plugin#464 already (marking the new property as experimental and unsupported)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darinpope @timja @jglick