-
Notifications
You must be signed in to change notification settings - Fork 103
Switching from using legacyInstanceId to the Jenkins controller URL for the jenkinsResourceTag value #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you resolve conflicts please? |
Looking into the failing checks now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks looks great!
I've done a basic sanity test and it seems fine.
@timja Hey, I see the PR got merged, but there are some issues on the master branch. Are these stopping the new release? How can I help fix them? |
I've triggered another build lets see if that works |
Switching from using legacyInstanceId to the Jenkins controller URL for the jenkinsResourceTag value, similar to the ec2-plugin. This could be a good way to handle duplicate legacyInstanceIds. It seems like this change could benefit multiple people.
This came from an issue where the Cleanup task was deprovisioning VMs after exactly 2 hours, interrupting any on-going builds. This is because the
cleanLeakedResouces()
method looks for candidate nodes to removed based on legacyInstanceId.Fixes #634
With this PR:
<jenkinsURL>|<timestamp>
<id>/<timestamp>
Testing done
mvn hpi:run
.Submitter checklist