Skip to content

Fix scaling issues and force private IP usage when usePrivateIP is set #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2025
Merged

Fix scaling issues and force private IP usage when usePrivateIP is set #636

merged 1 commit into from
Feb 14, 2025

Conversation

psciborek
Copy link
Contributor

  • Fix fleet scaling with shutdownOnIdle by cleaning up temporaryOffline state
  • Ensure private IP is always used when usePrivateIP is set
  • Prevent premature VM shutdown during initial VM creation for shutdownOnIdle

@psciborek
Fix scaling issues and force private IP usage when usePrivateIP is set
5c6274f 
 * Fix fleet scaling with shutdownOnIdle by cleaning up temporaryOffline state
 * Ensure private IP is always used when usePrivateIP is set
 * Prevent premature VM shutdown during initial VM creation for shutdownOnIdle
@psciborek
Copy link
Contributor Author

Details: #633

timja
timja approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@timja timja merged commit 3f8b46d into jenkinsci:master Feb 14, 2025
17 checks passed
@timja timja mentioned this pull request Feb 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psciborek @timja