Provide whitelist parity for MagicMock and Mock
#342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are whitelist entries for the `return_value` and `side_effect` attributes of the `unittest.mock.Mock` class. This change seeks to provide parity for the `unittest.mock.MagicMock` class, which is just a subclass of `Mock` but with default implementations of most of the magic methods. Standard library reference: https://docs.python.org/3/library/unittest.mock.html#magic-mock
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are whitelist entries for the
return_valueandside_effectattributes of the
unittest.mock.Mockclass. This change seeks toprovide parity for the
unittest.mock.MagicMockclass, which is just asubclass of
Mockbut with default implementations of most of the magicmethods.
Standard library reference:
https://docs.python.org/3/library/unittest.mock.html#magic-mock
Checklist:
I have added or adapted tests to cover my changes.tox -e fix-styleto format my code and checked the result withtox -e style.