Skip to content

Fix playing next audio item while shuffling #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2024
Merged

Fix playing next audio item while shuffling #4323

merged 2 commits into from
Dec 21, 2024

Conversation

nielsvanvelzen
Copy link
Member

oops

Changes

  • Fix useNextIndex never removing first element in ShuffleOrderIndexProvider and RandomOrderIndexProvider
  • Fix QueueService.next not respecting usePlaybackOrder and useRepeatMode properly

Issues

Regression from #4144

@nielsvanvelzen nielsvanvelzen added the bug Something isn't working label Dec 20, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.18.3 milestone Dec 20, 2024
@nielsvanvelzen nielsvanvelzen merged commit 25e79e9 into jellyfin:master Dec 21, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the please-play-next branch December 24, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.18.3
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @thornbill