Allow Exoplayer to invalidate the track selection on capabilities change #4686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
nielsvanvelzen
requested changes
May 30, 2025
If the capabilities of a device change, Exoplayer can invalidate the current selection to adhere to the new list of capabilities. This helps the Nvidia Shield and its content matching refresh rate option because, during the refresh rate switching period, the reported capabilities change. Without this flag, the device could reproduce audio as PCM instead of the expected passthrough. Addresses jellyfin#4067, additional context androidx/media#2258
nielsvanvelzen
approved these changes
May 30, 2025
|
Thanks for the PR and the effort you put into a good solution from the media3 side! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If the capabilities of a device change, Exoplayer can invalidate the current selection to adhere to the new list of capabilities.
This helps the Nvidia Shield and its content matching refresh rate option because, during the refresh rate switching period, the reported capabilities change. Without this flag, the device could reproduce audio as PCM instead of the expected passthrough.
Issues
Addresses #4067, additional context androidx/media#2258
I'm using "addresses" because I don't want to automatically close #4067. To fully fix it, we also need to bump media3 to the upcoming release (1.6.1+) because we need androidx/media@f825ad7 and androidx/media@93cf82d. On that matter, we probably just need to wait for them to tag a new release (bumping media3 is not a blocker for this PR).