Fix crash on startup #4640
Merged
Fix crash on startup #4640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should actually check for FragmentManager.isDestroyed and don't commit at-all (but write a warning message to the logs). Unfortunately I cannot reproduce the crash so I can also not test a potential fix. |
|
Thanks for taking a look! I adjusted the code as suggested. |
nielsvanvelzen
requested changes
May 10, 2025
app/src/main/java/org/jellyfin/androidtv/ui/browsing/DestinationFragmentView.kt
Outdated
Show resolved
Hide resolved
nielsvanvelzen
approved these changes
May 10, 2025
|
Thanks! |
mehrmoudi
pushed a commit
to mehrmoudi/jellyfin-androidtv
that referenced
this pull request
May 10, 2025
* Fix crash on startup * Changed condition evaluation order
3 tasks
nielsvanvelzen
pushed a commit
that referenced
this pull request
May 28, 2025
* Fix crash on startup * Changed condition evaluation order (cherry picked from commit a78db27)
This was referenced May 28, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Handles already running transactions. Not an android expert, but judging from the stack trace this could fix the issue.
Issues
#4572
#4441