Add custom connectivity checker for Coil that always claims to be connected #4513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some more context: when Coil thinks there is no network connection it will force OkHttp to load from cache, when OkHttp cannot load something from cache it will return a 504 response code. |
crobibero
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coil uses a "connectivity checker" to skip the network if it thinks there is no available connection. In Android this is sometimes detected by pinging a known host (e.g. google.com) which might fail for users that blackhole these hosts or only use the app on their local network.
Changes
Add custom connectivity checker that will always return
trueto force a network request to be made.Issues
Fixes #4379