Skip to content

Fix progress bar calculation #4483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

Fix progress bar calculation #4483

merged 1 commit into from
Feb 26, 2025

Conversation

lukas-fichtner
Copy link
Contributor

Hello there! This is my first Jellyfin PR – Feedback Welcome!

Changes

  • Corrected condition to properly check if the current time is within the program's duration.
  • Fixed progress percentage calculation using double division for accuracy.
  • Replaced getPremiereDate() with getStartDate() for correct program start time.
  • Refactored getRealTimeProgress() to ensure proper duration calculation.

Issues
Both Live TV progress bars are not working properly.
Couldn't find a matching issue, but this likely affects many. If one exists, please link it. Thanks!

nielsvanvelzen
nielsvanvelzen approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Seems like some of these slipped through in a migration I did some time ago 😅

@nielsvanvelzen nielsvanvelzen added this to the v0.19.0 milestone Feb 26, 2025
@nielsvanvelzen nielsvanvelzen added bug Something isn't working live-tv Issue related to the live TV feature backportable Change may be backported to a point release (remove label once cherrypicked) labels Feb 26, 2025
@nielsvanvelzen nielsvanvelzen enabled auto-merge (rebase) February 26, 2025 18:19
@nielsvanvelzen nielsvanvelzen merged commit 2a49b8b into jellyfin:master Feb 26, 2025
3 checks passed
@nielsvanvelzen nielsvanvelzen modified the milestones: v0.19.0, v0.18.5 Mar 1, 2025
@nielsvanvelzen nielsvanvelzen removed the backportable Change may be backported to a point release (remove label once cherrypicked) label Mar 1, 2025
@lukas-fichtner lukas-fichtner deleted the fix-progress-bar branch March 28, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working live-tv Issue related to the live TV feature
Projects
None yet
Milestone
v0.18.5
Development

Successfully merging this pull request may close these issues.
2 participants
@lukas-fichtner @nielsvanvelzen