Fix issue with syncplay group incorrectly playing content on creation #14360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
approved these changes
Jun 21, 2025
Shadowghost
approved these changes
Jun 21, 2025
crobibero
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a sync play group is created it is checking the sessions
FullNowPlayingItemproperty to determine if it should start playback. This property wasn't being set when playback stopped for the session. Newly created groups would then automatically start playback on items that were no longer being played on the session.Changes
Set
FullNowPlayingItemto null inRemoveNowPlayingItemmethod to ensureFullNowPlayingItemandNowPlayingItemare kept in sync on item removal and groups don't see a stale value