Skip to content

Conversation

nyanmisaka
Copy link
Member

Changes

  • Fix refreshing the library cannot delete old attachments

Issues

  • A user replaced an MKV video from one that included embedded fonts to one that did not, causing SSA/ASS subtitle rendering on the web to fail because the old attachment information was not deleted from the database.
image

Signed-off-by: nyanmisaka <nst799610810@gmail.com>
@sjorge
Copy link

sjorge commented Jul 13, 2025

How does this work with the recently added attachment/subtitle cleanup? Does that not rely on the db having the old paths? (I'm not sure and I can't figure out how it works by looking at the code (not even sure i was looking at the right spot))

Give the error, it seems to me the old attachments have either already be cleared from disk, or not yet. (I think the former, so removing them from the DB is fine?)

@nyanmisaka
Copy link
Member Author

nyanmisaka commented Jul 13, 2025

How does this work with the recently added attachment/subtitle cleanup? Does that not rely on the db having the old paths? (I'm not sure and I can't figure out how it works by looking at the code (not even sure i was looking at the right spot))

Give the error, it seems to me the old attachments have either already be cleared from disk, or not yet. (I think the former, so removing them from the DB is fine?)

[INF] [79] MediaBrowser.Providers.Movies.MovieMetadataService: File changed, pruning extracted data: /path/to/attachments

When Jellyfin detects that the video file has changed, or the user manually triggers a media library scan, the old attachment will be deleted, so the scheduled task should not have a chance to delete the attachment in this case.

In this case the attachment had been deleted, but the database still had the old information, which led to the failure of real-time extraction of attachment fonts and web rendering of subtitles. This fixes that mismatch.

@crobibero crobibero merged commit 25a3623 into jellyfin:master Jul 15, 2025
16 checks passed
@nyanmisaka nyanmisaka deleted the fix-attachments-refresh branch July 15, 2025 04:24
@aa1171842415
Copy link

最新版本jellyfin ,pve lxc docker部署,扫描媒体库会出现内存泄漏的问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants