Catch IOExceptions for GetFileSystemMetadata #13390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our `GetFileSystemEntries` method will throw when enumerating the file system, but its callers might consider the unhandled exceptions as the whole path is not available. This would cause a single problematic file to fail the enumeration, and could lead to unexpected side effects. HandleIOException gracefully by marking the files throwing as not exist to let the caller skip that file.
JPVenson
approved these changes
Jan 18, 2025
crobibero
approved these changes
Jan 18, 2025
Shadowghost
approved these changes
Jan 18, 2025
3766a88
into
jellyfin:release-10.10.z
15 of 16 checks passed
Bond-009
pushed a commit
that referenced
this pull request
Feb 3, 2025
Catch IOExceptions for GetFileSystemMetadata Original-merge: 3766a88 Merged-by: joshuaboniface <joshua@boniface.me> Backported-by: Bond_009 <bond.009@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
GetFileSystemEntriesmethod will throw when enumerating the file system, but its callers might consider the unhandled exceptions as the whole path is not available. This would cause a single problematic file to fail the enumeration, and could lead to unexpected side effects.HandleIOException gracefully by marking the files throwing as not exist to let the caller skip that file.
Note that the dotnet's method
EnumerateFileSystemInfosmay also throw and failed to build the file list. We can do little in this case. See #13093 for more info for this kind of issue.Changes
Issues
Fixes #13389