Never treat matroska as webm for audio playback #13345
Merged
+22
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would break browsers like Firefox where the matroska file cannot be played as audio file.
|
Thank you so much for your time! |
|
This also includes |
Server internal logic deal with normalized containers that does not differentiate mka and mkv. They have the same name. |
voronind-com
approved these changes
Jan 10, 2025
Shadowghost
approved these changes
Jan 10, 2025
crobibero
approved these changes
Jan 11, 2025
Bond-009
approved these changes
Jan 14, 2025
Bond-009
pushed a commit
that referenced
this pull request
Feb 3, 2025
Never treat matroska as webm for audio playback Original-merge: 344cc8b Merged-by: Bond-009 <bond.009@outlook.com> Backported-by: Bond_009 <bond.009@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would break browsers like Firefox where the matroska file cannot be played as audio file.
Changes
Issues
Fixes #13344