Skip to content

Fix typo in LibraryOptions #13097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2024
Merged

Fix typo in LibraryOptions #13097

merged 1 commit into from
Nov 26, 2024

Conversation

nielsvanvelzen
Copy link
Member

This option is not implemented in any of our clients in 10.10 so no migrations required. By default this value is empty which basically means no-op.

Changes

  • Fix typo in LibraryOptions
    • MediaSegmentProvideOrder -> MediaSegmentProviderOrder

Issues

@nielsvanvelzen nielsvanvelzen added bug Something isn't working breaking change: web api Includes a breaking change for the HTTP web API labels Nov 24, 2024
@jellyfin-bot
Copy link
Contributor

ABI Difference 

MediaBrowser.Model.dll
API compatibility errors between './abi-base/MediaBrowser.Model.dll' (left) and './abi-head/MediaBrowser.Model.dll' (right):
CP0002: Member 'string[] MediaBrowser.Model.Configuration.LibraryOptions.MediaSegmentProvideOrder.get' exists on ./abi-base/MediaBrowser.Model.dll but not on ./abi-head/MediaBrowser.Model.dll
CP0002: Member 'void MediaBrowser.Model.Configuration.LibraryOptions.MediaSegmentProvideOrder.set' exists on ./abi-base/MediaBrowser.Model.dll but not on ./abi-head/MediaBrowser.Model.dll
API breaking changes found. If those are intentional, the APICompat suppression file can be updated by specifying the '--generate-suppression-file' parameter.

@github-actions GitHub Actions
Copy link

Changes in OpenAPI specification found. Expand to see details.

What's Changed

GET /Library/VirtualFolders
Return Type:

Changed response : 200 OK

Virtual folders retrieved.

  • Changed content type : application/json

    Changed items (object):
    > Used to hold information about a user's list of configured virtual folders.

    • Changed property LibraryOptions (object)

      Updated LibraryOptions :

      • Added property MediaSegmentProviderOrder (array)

        Items (string):

      • Deleted property MediaSegmentProvideOrder (array)

  • Changed content type : application/json; profile="CamelCase"

    Changed items (object):
    > Used to hold information about a user's list of configured virtual folders.

    • Changed property LibraryOptions (object)

      Updated LibraryOptions :

      • Added property MediaSegmentProviderOrder (array)

      • Deleted property MediaSegmentProvideOrder (array)

  • Changed content type : application/json; profile="PascalCase"

    Changed items (object):
    > Used to hold information about a user's list of configured virtual folders.

    • Changed property LibraryOptions (object)

      Updated LibraryOptions :

      • Added property MediaSegmentProviderOrder (array)

      • Deleted property MediaSegmentProvideOrder (array)

POST /Library/VirtualFolders
Request:

Changed content type : application/json

Updated AddVirtualFolderDto :

  • Changed property LibraryOptions (object)

    Gets or sets library options.

    Updated LibraryOptions :

    • Added property MediaSegmentProviderOrder (array)

    • Deleted property MediaSegmentProvideOrder (array)

Changed content type : text/json

Updated AddVirtualFolderDto :

  • Changed property LibraryOptions (object)

    Gets or sets library options.

    Updated LibraryOptions :

    • Added property MediaSegmentProviderOrder (array)

    • Deleted property MediaSegmentProvideOrder (array)

Changed content type : application/*+json

Updated AddVirtualFolderDto :

  • Changed property LibraryOptions (object)

    Gets or sets library options.

    Updated LibraryOptions :

    • Added property MediaSegmentProviderOrder (array)

    • Deleted property MediaSegmentProvideOrder (array)

POST /Library/VirtualFolders/LibraryOptions
Request:

Changed content type : application/json

Updated UpdateLibraryOptionsDto :

  • Changed property LibraryOptions (object)

    Gets or sets library options.

    Updated LibraryOptions :

    • Added property MediaSegmentProviderOrder (array)

    • Deleted property MediaSegmentProvideOrder (array)

Changed content type : text/json

Updated UpdateLibraryOptionsDto :

  • Changed property LibraryOptions (object)

    Gets or sets library options.

    Updated LibraryOptions :

    • Added property MediaSegmentProviderOrder (array)

    • Deleted property MediaSegmentProvideOrder (array)

Changed content type : application/*+json

Updated UpdateLibraryOptionsDto :

  • Changed property LibraryOptions (object)

    Gets or sets library options.

    Updated LibraryOptions :

    • Added property MediaSegmentProviderOrder (array)

    • Deleted property MediaSegmentProvideOrder (array)

@nielsvanvelzen nielsvanvelzen mentioned this pull request Nov 24, 2024
Merged
@Bond-009 Bond-009 merged commit 572c5e2 into jellyfin:master Nov 26, 2024
21 checks passed
@nielsvanvelzen nielsvanvelzen deleted the venson-cant-spell branch November 26, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadowghost Shadowghost Shadowghost approved these changes

@JPVenson JPVenson JPVenson approved these changes

@Bond-009 Bond-009 Bond-009 approved these changes

+1 more reviewer

@jumoog jumoog jumoog approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
breaking change: web api Includes a breaking change for the HTTP web API bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nielsvanvelzen @jellyfin-bot @Shadowghost @jumoog @JPVenson @Bond-009