Update projects to .NET 9 #13023
Merged
Update projects to .NET 9 #13023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gauvino
reviewed
Nov 12, 2024
| @@ -1,15 +1,15 @@ | |||
| { | |||
| "name": "Development Jellyfin Server - FFmpeg", | |||
| "image":"mcr.microsoft.com/devcontainers/dotnet:8.0-jammy", | |||
| "image":"mcr.microsoft.com/devcontainers/dotnet:9.0-jammy", | |||
There was a problem hiding this comment.
Maybe should now switch to noble ?
| @@ -1,15 +1,15 @@ | |||
| { | |||
| "name": "Development Jellyfin Server", | |||
| "image":"mcr.microsoft.com/devcontainers/dotnet:8.0-jammy", | |||
| "image":"mcr.microsoft.com/devcontainers/dotnet:9.0-jammy", | |||
crobibero
reviewed
Nov 12, 2024
Comment on lines
-295
to
-302
|
|
||
| // Increase the max http request limit | ||
| // The default connection limit is 10 for ASP.NET hosted applications and 2 for all others. | ||
| ServicePointManager.DefaultConnectionLimit = Math.Max(96, ServicePointManager.DefaultConnectionLimit); | ||
|
|
||
| // Disable the "Expect: 100-Continue" header by default | ||
| // http://stackoverflow.com/questions/566437/http-post-returns-the-error-417-expectation-failed-c | ||
| ServicePointManager.Expect100Continue = false; |
There was a problem hiding this comment.
Are these just no longer needed?
There was a problem hiding this comment.
In modern .NET, HttpClient does not take into account any configurations set on ServicePointManager.
Not sure how long this has been the case
JPVenson
approved these changes
Nov 12, 2024
Shadowghost
approved these changes
Nov 12, 2024
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
crobibero
approved these changes
Nov 16, 2024
|
Latest build still uses dotnet 8.0. Is this by design or just an accident that the commit is not merged into release? |
10.10.x is net8.0, 10.11.x will be net9.0. |
Lampan-git
pushed a commit
to Lampan-git/jellyfin
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.