-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Backport 10.11 API enum changes #13835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport 10.11 API enum changes #13835
Conversation
…3821) Enums in response model with no nullability or default value will make the API very fragile as each extension to the enum will break the API for some clients, but a lot of enums actually do have an unknown value which should be used as a default. This set all model properties that are non-nullable using an enum that has an Unknown member in 10.10, except MediaStream.VideoRangeType which is refactored in jellyfin#13277 (cherry picked from commit 4a4fef8)
Do not apply stable backport label to this PR. These changes are already in master! |
Changes in OpenAPI specification found. Expand to see details.What's Changed
|
Changes
This PR backports #13821 and part of #13277 to use the "Unknown" enum member as default value for all non-nullable properties in the API using an enum that has an Unknown member.
This is specifically needed in a 10.10 backport so a client build with the 10.10.7 API can still read responses from a 10.11 server now with the breaking API changes from #13277.
Issues