Fix regression where "Search for missing metadata" not handling cast having multiple roles #13720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobibero
approved these changes
Mar 16, 2025
Shadowghost
approved these changes
Mar 16, 2025
Bond-009
approved these changes
Mar 20, 2025
Bond-009
pushed a commit
that referenced
this pull request
Mar 20, 2025
Fix regression where "Search for missing metadata" not handling cast having multiple roles Original-merge: 91ca81e Merged-by: Bond-009 <bond.009@outlook.com> Backported-by: Bond_009 <bond.009@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix regression from #13618 where it doesn't handle cast having multiple roles, as this it give the values from the first occurrence to everything else, and as null values are valid for sortOrder it overwrites the sortOrder of those roles which shouldn't have any.
This is done by grouping the target by name and then looping through the name groupings.
Issues